We discovered a 7-year old performance issue in Elixir (2020)

We discovered a 7-year old performance issue in Elixir (2020)(code.tubitv.com)

85 points by s3cur3 3 years ago | 13 comments

d3nj4l 3 years ago |

Love the fact that they got the PR through in 10 minutes. Jose Valim is genuinely one of the warmest and most welcoming language BDFLs I've ever seen, and I don't believe Elixir would be as great without him.

sph 3 years ago | |

He's everywhere. You open a issue on one of the dozen most used Elixir libraries, and he'll answer by end of day. I envy his work ethic and I appreciate how he's always very patient with everybody.

In general everyone at dashbit seem to be very warm people. Good culture fosters good culture.

prophesi 3 years ago | |

He's helped me several times in the #elixir freenode channel as well. And of course their elixir books are a godsend.

mercer 3 years ago | | |

Same here. More than once I asked a question on the channel (now on Libera?) and the first person to answer would be Jose. I can highly recommend the series of interviews that the Thinking Elixir podcast did with him where they go through the entire history of Elixir versions:

https://podcast.thinkingelixir.com/

albatross13 3 years ago | | |

As someone who loves Elixir, but is bad at it, which books are you referring to? I will buy them instantly.

Kabie 3 years ago |

Interestingly enough, I find myself rarely using regex with Elixir. Thanks to erlang's excellent pattern matching syntax for binary.

throwawaymaths 3 years ago | |

I either use pattern matching for easy things or reach for nimble parsec.

AtNightWeCode 3 years ago | |

Regex should be kept to a minimum in an API because it is a known DOS attack vector. Sounds a bit worrying if they also have parameters that affect execution time.

pmontra 3 years ago |

Redirected to gdpr.tubitv.com

> Tubi is the largest free movie and TV streaming service in the US. Unfortunately, we're not currently available in your area.

So I can't even know how it works. Wikipedia to the rescue https://en.wikipedia.org/wiki/Tubi

It seems to be ad supported.

ReactiveJelly 3 years ago | |

If you turn off JS, this archive.org link kinda works https://web.archive.org/web/20201226070313/https://code.tubi...

But I think the images are loaded via JS, so you only get text.

There is some strange redirect loop (302, 307, 302, 307...) if you leave JS on. Probably some bug in Medium's JS, and it confused the archiver?

randomhodler84 3 years ago |

2020 post. Good write up on technical issue that demonstrated tooling and process to identify a superfluous regex compile in the base framework. Quick patch and suddenly it’s faster for everyone! Neat!