Ask HN: Do you read your own PR?

5 points by bubblebeard 263 days ago | 5 comments

As part of my QA process, I always read through my own pull request before submitting it, to ensure I fix any obvious mistakes I made before it's reviewed by my colleagues.

No one I've ever worked with seems to do the same, am I alone in this behavior?

motorest 263 days ago |

> No one I've ever worked with seems to do the same, am I alone in this behavior?

You are not alone. I also read and re-read my PRs, and it pains me when people from my team post them with a lame and mysterious "misc fixups" comment.

This turns into something particularly bad when you try to audit a change and both the commit message and the PR say nothing about nothing.

shortrounddev2 263 days ago |

I check the commit messages to make sure i didnt use my personal git credentials (as i sometimes do), i comb through the git diff to make sure the changes are all what theyre supposed to be. i avoid whitespace or stylistic changes because they distract from the main point. I run git diff and git status maybe 10 times befire i submit a PR

my coworkers, from what i can tell, are much more incorrectly confident in the quality of their PRs

yawgmoth 263 days ago |

Always, and sometimes I'll add authors notes as comments on the PR. This is actually one reason I dislike "all threads resolved" as a criterion for approving PRs (or specifically GitLab PRs).

WantonQuantum 263 days ago |

I definitely read through the changes in my PRs to make sure I haven't done anything obviously wrong.

abstractspoon 263 days ago |

I always do this especially to weed out unnecessary changes made during an exploratory phase